Added testcase to demonstrate rector#8977#440
Merged
samsonasik merged 1 commit intorectorphp:mainfrom Jan 16, 2025
Merged
Conversation
Member
|
Thanks! Are all the docblock lines needed to trigger the bug? I've just tried to remove the first one, and bug remains. |
andrewnicols
force-pushed
the
rector8977
branch
from
18b94e2 to
05026e7
Compare
Contributor
Author
|
No - I've simplified the test to the bare minimum. |
Member
|
@andrewnicols please remove these commited files:
|
Where an inline docblock is used in another tag, all subsequent tags are removed. rectorphp/rector#8977
andrewnicols
force-pushed
the
rector8977
branch
from
05026e7 to
f92b5c6
Compare
Contributor
Author
|
Done - Not sure how those got there. I literally cloned the repo to create these tests. Edit: The tests themselves pollute the test fixtures directories and if you abort the test midway through you end up with these. |
Member
|
Thank you @andrewnicols |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Where an inline docblock is used in another tag, all subsequent tags are removed.
rectorphp/rector#8977
I've tried to keep this as small as possible but have deliberately incldued: